Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contrast-minimum.html #3240

Closed

Conversation

bruce-usab
Copy link
Contributor

@bruce-usab bruce-usab commented Jun 13, 2023

This PR incorporates feedback from survey:
https://www.w3.org/2002/09/wbs/35422/wcag2x-backlog1/results#xq29

Note that this PR is changes to PR mentioned in survey.

I cannot figure out why diff on line 23 looks like the paragraph was replaced. Change is only in last sentence, and all I did is (1) remove parenthesis, and (2) add the word "headings" after "white".

@bruce-usab
Copy link
Contributor Author

This PR is responsive to comments on Question 6 in AGWG survey for call on 6/13/2023.

Closes #2033

@bruce-usab bruce-usab linked an issue Jun 13, 2023 that may be closed by this pull request
@bruce-usab bruce-usab marked this pull request as ready for review June 13, 2023 15:40
@bruce-usab
Copy link
Contributor Author

@detlevhfischer -- I cannot now find your comments in PR #2037

@@ -13,15 +13,14 @@ <h1>Understanding Contrast (Minimum)</h1>
<h2>Intent of Contrast (Minimum)</h2>


<p>The intent of this Success Criterion is to provide enough contrast between text and its background so that it can be read by people with moderately low vision.
<p>The intent of this Success Criterion is to provide enough contrast between text and its background so that it can be read by people with limited vision, including color vision deficiencies.
Copy link
Contributor

@mbgower mbgower Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does make it less clear that the minimum contrast target is understood by the working group as not solving readability for all. Was this change intended to remove the phrase "low vision" or due to concern with the word moderately? If the former, how about "... with moderately limited vision,..."?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my motivation was to point to color vision deficiencies as being particularly addressed.

Copy link
Contributor

@mbgower mbgower Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern is that that describes a condition, but we're actually talking about people. And there was a prior inference in the language that the WG understood this didn't solve things for everyone.
We can solve by the addition of "more" and a couple of other words

Suggested change
<p>The intent of this Success Criterion is to provide enough contrast between text and its background so that it can be read by people with limited vision, including color vision deficiencies.
<p>The intent of this Success Criterion is to provide enough contrast between text and its background so that it can be read by more people with limited vision, including those with color vision deficiencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of the two above, I prefer the original, since this about intent. But I agree that we should not overstate the efficacy of the SC. How about:

The intent of this Success Criterion is to provide enough contrast between text and its background so that reading is easier for some people with limited vision, including some people with color vision deficiencies.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like both new suggestions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest:

The intent of this Success Criterion is to provide enough contrast between text and its background so that reading is easier for some people with limited vision, including people with color vision deficiencies.

Co-authored-by: Mike Gower <mikegower@gmail.com>
@bruce-usab
Copy link
Contributor Author

Apologies, my novel PR to PR caused much confusion. I am taking a fresh stab at this, with a third PR.

@alastc
Copy link
Contributor

alastc commented Aug 14, 2023

Clarified with Bruce, this is superseded by #3284

@alastc alastc closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Understanding for Contrast does not call out Color Blindness
4 participants